TBD54566975 / dwn-sdk-js

Decentralized Web Node (DWN) Reference implementation
https://identity.foundation/decentralized-web-node/spec/
Apache License 2.0
326 stars 105 forks source link

Setting `lowS: false` by default for verification of secp256k1 signatures #811

Closed aniketh-varma closed 1 month ago

aniketh-varma commented 1 month ago

What type of PR is this? (check all applicable)

Description

This PR adds the feature of setting the lowS flag to be false by default for the verification of secp256k1 signatures.

Related Tickets & Documents

Resolves #714

Mobile & Desktop Screenshots/Recordings

Added code snippets?

Added tests?

No tests? Add a note

Added to documentation?

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.71%. Comparing base (8b6eb13) to head (b28da60). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #811 +/- ## ======================================= Coverage 98.71% 98.71% ======================================= Files 74 74 Lines 11469 11469 Branches 1652 1652 ======================================= Hits 11322 11322 Misses 141 141 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.