Closed LiranCohen closed 6 months ago
Attention: Patch coverage is 70.83333%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 94.23%. Comparing base (
40e758c
) to head (d78eba3
).
Files | Patch % | Lines |
---|---|---|
src/http-api.ts | 69.56% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@thehenrytsai spent a little more time on it to make this a more thoughtful PR. Added some notes to the readme.
In a previous PR some(much desired) version information was added to the
/info
endpoint, however in certain environments(our docker container) this blows up.This PR prevents the endpoint from blowing up, while also providing some optionality and defaults to fall back on and bumps version to
v0.1.13
Added the text below to the
README.md
file:server
is read from theprocess.env.npm_package_name
variable thatnpm
provides. If that does not exist, it will check for aDWN_SERVER_PACKAGE_NAME
environment variable set by the user, or otherwise it will default to@web5/dwn-server
.version
andsdkVersion
are read from thepackage.json
file. It will locate the file's path either from theprocess.env.npm_package_json
variable thatnpm
provides. If that does not exist, it will check for aDWN_SERVER_PACKAGE_JSON
environment variable set by the user, or otherwise it will default to/dwn-server/package.json
which is the path within the default Docker container build.