TBD54566975 / dwn-server

DWN server - host anywhere publicly accessible for DIDs to use
Apache License 2.0
40 stars 41 forks source link

Replace eslint `sort-imports` rule with prettier plugin #57

Closed adam4leos closed 1 year ago

adam4leos commented 1 year ago

Background:

Replace eslint sort-imports rule with prettier plugin

Task Details:

currently we have an eslint rule supporting sort-imports rule.

'sort-imports': [
      'error',
      {
        ignoreCase: true,
        ignoreDeclarationSort: false,
        ignoreMemberSort: false,
        memberSyntaxSortOrder: ['none', 'all', 'single', 'multiple'],
        allowSeparatedGroups: true,
      },
    ],

Picking Up This Issue:

Questions:

Resources:

Remember, communication is key! If you have any questions or face any challenges, we're here to help so please don't hesitate to reach out.

Good Luck! 🍁

Opssy commented 1 year ago

@adam4leos I need more clearification

adam4leos commented 1 year ago

@Opssy currently we have an eslint rule supporting sort-imports rule.

'sort-imports': [
      'error',
      {
        ignoreCase: true,
        ignoreDeclarationSort: false,
        ignoreMemberSort: false,
        memberSyntaxSortOrder: ['none', 'all', 'single', 'multiple'],
        allowSeparatedGroups: true,
      },
    ],

We'd like to remove this rule from eslint and instead use plugin for prettier, possibly https://github.com/trivago/prettier-plugin-sort-imports to match the eslint rule as close as possible atm

Opssy commented 1 year ago

okay

EbonyLouis commented 1 year ago

@Opssy Hi, is this an issue you'd like to work on for Hacktoberfest?

Opssy commented 1 year ago

@EbonyLouis Yes

EbonyLouis commented 1 year ago

@Opssy yay! its been assigned to you.

I'd also like to note that Hacktoberfest officially kicks off on October 1st. Contributions made before the event may not be eligible for the challenge. However, feel free to start working on it, but I'd recommend holding off on submitting your PR until the event begins.

to be eligible for Hacktoberfest's official prizes make sure you're registered, registration is now open! Reach out if you need any help 🥳

jerempy commented 1 year ago

picked it up since it looks like 3 weeks with no activity. PR linked above

EbonyLouis commented 1 year ago

@jerempy thanks!