search

TBD54566975 / dwn-server

DWN server - host anywhere publicly accessible for DIDs to use
Apache License 2.0
40 stars 41 forks source link

adding subscription handling to dwn server. #68

Closed andorsk closed 8 months ago

andorsk commented 1 year ago

Server updates for #508. In draft as #508 is still in progress and still working out some kinks. Subscriptions only work on web socket connections. It's a little different than the rest of the processMessage records, as the server has to manage the live socket connection pipes given by the dwn.

In DRAFT until everything is together and also some of the tests aren't working yet (fixing today).

Do NOT merge yet, but sharing for transparency about direction.

codesandbox[bot] commented 1 year ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

andorsk commented 1 year ago

@finn-tbd if you have any time, can you take a look and give some feedback? I feel like there's some better ways to handle a few of these pieces, but wanted to get your thoughts if possible.

finn-tbd commented 1 year ago

sorry i think this got lost in the shuffle. I made one comment but i'm hoping to do more in depth looking later today.

finn-tbd commented 1 year ago

i looked through this more, it seems fine for now.

LiranCohen commented 8 months ago

Closing in favor of: https://github.com/TBD54566975/dwn-server/pull/107