Reenable secret validation.

TBD54566975 / ftl

FTL - Towards a 𝝺-calculus for large-scale systems

Apache License 2.0

18 stars 6 forks source link

Reenable secret validation. #1972

Open matt2e opened 1 week ago

matt2e commented 1 week ago

Steps to repro:

Add a module that defines a secret
Set the secret using ftl secret set ...

We get this error:

ftl: error: unknown: declaration "secretname" not found

Looks like we are looking up the active schema before setting a secret and erroring if it is not found. And a schema is only active if it was successfully deployed with runners. But when creating a secret that has not been set yet it can not deploy.

alecthomas commented 1 week ago

Very surprising no test covers this...

alecthomas commented 1 week ago

@safeer when you take a look at this, mind adding an integration test for it please?

matt2e commented 6 days ago

Reverting here to unblock other changes I'm working on with secrets: https://github.com/TBD54566975/ftl/pull/1978

matt2e commented 6 days ago

oh and btw ftl-project-dr.toml you'll need to add back in a name value. I'd added that in with in a subsequent commit but that is lost due to the revert