TBD54566975 / tbdex-pfi-exemplar

4 stars 8 forks source link

tbDEX PFI 🤝 FTL #7

Closed KendallWeihe closed 7 months ago

KendallWeihe commented 9 months ago

This is a large PR, apologies for that. Going to make an attempt to make it digestible here in the description, so please read carefully before proceeding.

Why?

The elevator pitch here goes something like: Build a tbDEX PFI (by building a HTTP API), using FTL, for three reasons:

  1. Provide usable feedback for both tbDEX & FTL
  2. Useful as a developer integration tool
  3. Because it's cool 😎

What?


Where?

I'm not sure we want to merge this in. I'm sure we'll want this, but I'm not sure we want it here in the tbdex-pfi-exemplar code repo. If we yank it out, and place it somewhere else, the only dependency we'll need to duplicate over, is the items under the db/ directory; otherwise, everything is self contained within the ftl/ repo.


If you want to get your hands dirty, then follow the README -- it's crude, but should provide enough to get off-zero.

[Note]: if you want to do this prior-to us cutting a 0.7.0-beta tbdex-kt release then you'll need to gradle publishToMavenLocal in tbdex-kt such that this project can pull from your local JARs.


Current Limitations


Before merging

KendallWeihe commented 9 months ago

what mains makes maintaining it cleaner?

Intuitively, I would bet keeping git repos language-specific would be the wise move. Which means, we should have separate tbdex-pfi-exemplar-js and tbdex-pfi-exemplar-ftl repos.

michaelneale commented 9 months ago

@KendallWeihe yeah that is the pattern we use elsewhere

michaelneale commented 9 months ago

@KendallWeihe I would almost call this tbdex-pfi-examplar-kt - and make the focus on that? FTL is the "detail" on how to run it perhaps? can that work?

KendallWeihe commented 9 months ago

call this tbdex-pfi-examplar-kt

Yeah totally agree

michaelneale commented 7 months ago

had any more thoughts on this @KendallWeihe or should close it/move it?

KendallWeihe commented 7 months ago

had any more thoughts on this @KendallWeihe or should close it/move it?

oops, still lingering

closing for now, can use for reference down the road, thanks!