#214 Restructure hosting of test vectors

TBD54566975 / tbdex

56 stars 26 forks source link

#214 Restructure hosting of test vectors #215

Closed diehuxx closed 10 months ago

diehuxx commented 10 months ago

Separate test vectors into one test vector per file. Set up a validation script to ensure all test vectors follow a common format.

See hosted/test-vectors/protocol/README.md for how to use and generate test vectors

See https://github.com/TBD54566975/tbdex-js/pull/129 for how implementations can use git submodules to consume test vectors and other hosted materials.

diehuxx commented 10 months ago

Instead of using this entire repo as a submodule in implementation repos (tbdex-js, tbdex-kt, etc.), let's pull the JSON schemas and test vectors into their own repo called tbdex-interop-suite, which is included as a submodule here and in implementation repos.

KendallWeihe commented 10 months ago

Nice! A coupla thoughts...

Should we also move scripts/test-vector-validation?
The GitHub Workflow still relies on the hosted/ directory, is this a bug?

KendallWeihe commented 10 months ago

Nice! A coupla thoughts...

Should we also move scripts/test-vector-validation?

The GitHub Workflow still relies on the hosted/ directory, is this a bug?

As I was typing that out, I see you committed the files back. Sorry I may be throwing this for a loop.

diehuxx commented 10 months ago

@KendallWeihe Sorry for the confusion! In a thread on Discord, we decided against puttin the vectors into a separate repo. So, I reverted to keeping the vectors in hosted/