TBD54566975 / tbdex

56 stars 25 forks source link

Split `Offering.payin/outMethod.kind` into specific fields #233

Closed jiyoontbd closed 6 months ago

jiyoontbd commented 7 months ago

Currently, the example for Offering.paymentMethod.kind is something like

image

Other examples include BANK_SomeBankName or MOMO_MPESA

However, from the perspective of a wallet rendering the kind, we want the ability to break down the type of payment (i.e. bank, momo, etc) from the provider of payment (i.e. Chase, M-Pesa, etc). This is especially useful if a PFI has multiple payment method who has 1 type but many providers of that type, i.e. enabling MOMO via M-PESA or via MTN.

Exact names / how to narrow the definition of kind are to be determined.

jiyoontbd commented 7 months ago

@ethan-tbd would you be able to paste in a screenshot of the page were working on yesterday? 🙏

ethan-tbd commented 7 months ago

For additional context, in order for the Yellow Card PFI to process a SelectedPaymentMethod in the RFQ, the client application is required to specify both a payment type (i.e. bank or mobile money) and the specific provider of that payment type (e.g. United Bank for Africa or M-Pesa). However, since our offering only has a singular kind field to describe the payment method, Yellow Card is using prefixes in their offering PaymentMethod.kind field to denote the payment type and the corresponding suffix to denote the payment provider (e.g. BANK_United Bank for Africa, MOMO_MPESA).

Simulator Screenshot - iPhone 15 Pro Max - 2024-02-07 at 08 51 40 Simulator Screenshot - iPhone 15 Pro Max - 2024-02-07 at 08 51 45

kirahsapong commented 7 months ago

ccing myself to follow along

mistermoe commented 6 months ago

addressed by #261