search

TBD54566975 / tbdex

56 stars 25 forks source link

Consider `Close.success` exclusively valid for creation by the PFI #288

Closed KendallWeihe closed 5 months ago

KendallWeihe commented 5 months ago

Ideated by @thehenrytsai here

  1. Allow success to be exclusively used by the FPI to signal a "successful close" of the transaction.
  2. If Alice tried to use success at all, treat it as an invalid message, even if it is set to false, just for simplicity of processing.

Relevant to the additions here

Proposal here would be to update the spec with the above rules, and then notify implementors of additions needed

Requesting input from @mistermoe @phoebe-lew @jiyoontbd @kirahsapong @diehuxx

KendallWeihe commented 5 months ago

For the sake of collaboration, and the fine-detail requirement of the spec language, it's best to open a PR for the sake of this proposal https://github.com/TBD54566975/tbdex/pull/289

KendallWeihe commented 5 months ago

The major change here being: we're locking down Alice's ability to request a cancellation of an actively executing Order. Which is to say, once Alice submits an Order, they cannot undo that. We could open up that can of worms, but it creates additional complexity. If we feel we need that requirement then please voice that and we'll open that discussion.

KendallWeihe commented 5 months ago

If we feel we need that requirement then please voice that and we'll open that discussion.

Actually, if we decide that's a requirement, then we'll decline this proposal and keep the spec as-is.

kirahsapong commented 5 months ago

i originally thought no takesies backsies either. but there was this message from moe 19 days ago

also, i think we will need to allow Close after an order is submitted due to EFTA regulatory requirements for remittances. Remittance Transfer rules necessitate a 30min cancellation window be allowed for the sender unless the remittance has already been fulfilled

if this is true we have to allow a close after order

KendallWeihe commented 5 months ago

Alright, I'm closing this as not accepted, per the EFTA regulatory requirement. Thanks for pointing that out @kirahsapong

The point to call out here is one of DX, that Alice may submit a Close but that doesn't guarantee a successful cancellation, and that our SDKs cannot make any enforcement of that, so it's up to the application to derive that state

jiyoontbd commented 5 months ago

adjusting why we closed - from what i'm reading, this is a wontdo