search

TBD54566975 / tbdex

56 stars 25 forks source link

Consider extending RFQs to better accommodate other claim types #300

Open diehuxx opened 5 months ago

diehuxx commented 5 months ago

Context: https://github.com/TBD54566975/tbdex/pull/294#pullrequestreview-1964982715

one thing I realize, is that there is an assumption baked into this proposal that the claims included in the presentation submission are issued in a format that's not selectively disclosable. if, for example, we accepted claims that were SD-JWT we would run into a problem where we would need to submit disclosures of the SD-JWT in multiple places.

it seems like we should decouple the requirements of the submission from its credential format.

this could look like include a new type of claim format so that the concern of disclosing PII is handled at the presentation layer instead of the protocol layer in a privateData field.

I understand time is of the essence, so I am OK with the proposal as-written even though I do have some hesitations around it. May be good to create a follow-up issue to continue this discussion and track improvements, like what we should do when we do adopt SD-JWT or other credential formats.

@decentralgabe Is there any other context you would add?

decentralgabe commented 5 months ago

Explore whether it is feasible to change claims to be a presentation submission. This would allow us to remove private and define new claim types that contain disclosable/disclosed data formats.