Closed mistermoe closed 2 months ago
This PR doesn't accommodate for the fact that id can be omitted entirely and if so, should be set to the jwk thumbprint of the respective PublicKeyJwk.
@mistermoe is using the thumbprint in some standard somewhere? I know we're doing that in various places, but it has implications when integrating with key manager services, which can maintain their own reference of a key alias.
@KendallWeihe , from the did:dht
spec here
unrelated, re:
but it has implications when integrating with key manager services, which can maintain their own reference of a key alias.
can you provide a concrete example of what you mean when you say this?
can you provide a concrete example of what you mean when you say this?
Looks like most key manager services support defining a custom key alias, so no I don't have a concrete example. But even so, it's additional abstraction because the key id defined by the given key manager/store/enclave is the ultimate source of truth.
Summary
Included a short-term fix for a
did:dht
issue rasied here: https://github.com/TBD54566975/tbdex-go/pull/20#discussion_r1566623560Details
Fixed value resolution such that
vm.ID
s are always absolute.main
wasn't accounting for the fact thatid
in a verification method TXT record is only the fragment (excluding'#'
) which was causing resolved did docs to look like this:vm.Controller was not being set unless it was explicitly set in a verification method's TXT record. Per the spec, This PR sets
vm.Controller
todocument.ID
if it isn't explicitly set in the txt record