search

TBD54566975 / web5-go

Apache License 2.0
10 stars 6 forks source link

Fix: Added BEP44 decode to DHT resolve #45

Closed mihai-chiorean closed 6 months ago

mihai-chiorean commented 6 months ago

Summary

The DHT resolve I introduced missed the bep44 encoding steps, which is part of the DHT Spec https://did-dht.com/#read I've added the decoding logic and updated the tests

Area of improvement

Adding the bencode package adds a very high number of dependencies to go.sum. The bencoding support needed here can be implemented in the repo to avoid adding so many dependencies.

mistermoe commented 6 months ago

should we merge https://github.com/TBD54566975/web5-go/pull/46 into this branch first?

will do a full review of diddht package as part of the Create PR