search

TBD54566975 / web5-go

Apache License 2.0
10 stars 6 forks source link

Fix all linting errors #50

Closed KendallWeihe closed 6 months ago

KendallWeihe commented 6 months ago

Originally thought of with this issue https://github.com/TBD54566975/web5-go/issues/49

KendallWeihe commented 6 months ago

@mihai-chiorean linting is still failing because of a lot of failures in the diddht package. I started to correct some but felt maybe you should weigh in first. I'm okay with merging this and fixing the diddht issues in a follow-up if it means this doesn't linger.

alecthomas commented 6 months ago

LGTM but I'd probably just go and fix the ones in libdht too so you don't merge a breaking build into main.

KendallWeihe commented 6 months ago

Alright, I fixed all of the remaining linting errors, but I may have been slightly liberal with the //nolint comment 🙂 lol

mihai-chiorean commented 6 months ago

@mihai-chiorean linting is still failing because of a lot of failures in the diddht package. I started to correct some but felt maybe you should weigh in first. I'm okay with merging this and fixing the diddht issues in a follow-up if it means this doesn't linger.

I'll fix them and make a PR

KendallWeihe commented 6 months ago

@mihai-chiorean I'm going to go ahead and merge this so it doesn't linger, feel free to use that last commit of mine to check through if I got anything wrong