search

TBD54566975 / web5-go

Apache License 2.0
7 stars 6 forks source link

Consider adding support for N-subject VC's where N > 1 #72

Open KendallWeihe opened 4 months ago

KendallWeihe commented 4 months ago

Our vc.Sign() creates a JWT under the assumption our VC only has a single subject, but what about if we have VCs with more-than-1 subjects?

Originally thought of here https://github.com/TBD54566975/web5-go/pull/60/files#r1502661684

m-rit commented 1 month ago

Hi @KendallWeihe, Can I work on a PR to add an enhancement or an example case to support multiple subjects? I've used this repo for personal projects, and I'd like to contribute to the open issues.

Thanks!

KendallWeihe commented 1 month ago

Hey @m-rit 👋

Right now it appears we're locked in for only a single subject for our web5 specification. However, this will likely grow overtime, but at this point in time I'd advise us against going against what's specified in the web5-spec repo. We're in the midst of opening a committee and we'll have a subsequent Working Group for the web5 spec, wherein it'll be appropriate to make proposals such as this ticket makes (this ticket was opened before a lot of what I just said was structured).

For now, let's leave this ticket open, but not plan on doing until the Working Group can come to it.

@m-rit there are lots of other tickets on the backlog though, if you want to contribute feel free to pick up another. Thanks!