search

TBD54566975 / web5-go

Apache License 2.0
7 stars 6 forks source link

Fix linting #87

Closed KendallWeihe closed 4 months ago

KendallWeihe commented 4 months ago

Honestly, both of these linting rules are annoying to me, but we have followed them elsewhere so I'm adding this for the sake of consistency

KendallWeihe commented 4 months ago

Suddenly I'm seeing that linting is passing in the pipeline on main, but failing locally... what the heck is going on...

KendallWeihe commented 4 months ago

Interesting... for some reason I had a newer version of golangci-lint in my .hermit/ directory. @alecthomas are there any docs around what the .hermit/ directory is and the DX? (briefly poked around here but didn't see anything https://cashapp.github.io/hermit/usage/) I presume it's a cache of sorts, but odd that it gets out-of-whack with what was pinned in the bin/ directory.

I've gone ahead and updated our golangci-lint in this PR's most recent commit

For proof that these changes are needed https://github.com/TBD54566975/web5-go/actions/runs/8068904849

alecthomas commented 4 months ago

That directory is where binaries installed by go install end up. Something (not Hermit) on your system installed golangci-lint explicitly. It's nothing to do with Hermit except that it overrides GOBIN and adds it to PATH.