search

TBD54566975 / web5-kt

Apache License 2.0
7 stars 9 forks source link

Update did:dht resolution on invalid uri #237

Closed nitro-neal closed 3 months ago

nitro-neal commented 5 months ago

Overview

Update did:dht resolution

Description

Updates did:dht resolution error to be in line with our js implementation and test vectors

When an invalid did uri is given to the dht resolver it should come back with invalidDid error

codecov[bot] commented 5 months ago

Codecov Report

Merging #237 (ace58d4) into main (f3e8a88) will increase coverage by 4.28%. Report is 2 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head ace58d4 differs from pull request most recent head 7752c04. Consider uploading reports for the commit 7752c04 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #237 +/- ## ========================================== + Coverage 75.78% 80.07% +4.28% ========================================== Files 43 37 -6 Lines 1900 2203 +303 Branches 342 312 -30 ========================================== + Hits 1440 1764 +324 + Misses 313 299 -14 + Partials 147 140 -7 ``` | [Components](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/237/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | Coverage Δ | | |---|---|---| | [credentials](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/237/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `82.06% <ø> (+1.06%)` | :arrow_up: | | [crypto](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/237/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `45.07% <ø> (+0.95%)` | :arrow_up: | | [dids](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/237/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `89.73% <100.00%> (+3.19%)` | :arrow_up: | | [common](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/237/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `69.44% <ø> (+3.14%)` | :arrow_up: |
jiyoontbd commented 4 months ago

@nitro-neal 👋 would you like to add a test for the parserexception (i think just adding one more test case to resolve.json in web5-spec submodule?) and then we can go ahead and merge this smol pr

nitro-neal commented 4 months ago

Added unit test 👍