TBD54566975 / web5-kt

Apache License 2.0
8 stars 9 forks source link

Replace usage of nimbusds Algorithm and Curve with our own enums #239

Closed jiyoontbd closed 5 months ago

jiyoontbd commented 5 months ago

Overview

Eliminating use of Curve and Algorithm from nimbusds dependency and instead using our own enums JwaCurve and Jwa, respectively. Adopting use of AlgorithmId which is a combination of JwaCurve and Jwa.

This PR is the first step to remove dependency on the nimbusds library and preventing exposing their types through our public API surface.

Description

Impact

How Has This Been Tested?

Checklist

Before submitting this PR, please make sure:

References

JWA spec

codecov[bot] commented 5 months ago

Codecov Report

Merging #239 (c205068) into main (1486951) will decrease coverage by 0.46%. The diff coverage is 47.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #239 +/- ## ========================================== - Coverage 80.04% 79.59% -0.46% ========================================== Files 37 38 +1 Lines 2200 2220 +20 Branches 312 316 +4 ========================================== + Hits 1761 1767 +6 - Misses 299 314 +15 + Partials 140 139 -1 ``` | [Components](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/239/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | Coverage Δ | | |---|---|---| | [credentials](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/239/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `82.16% <100.00%> (+0.09%)` | :arrow_up: | | [crypto](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/239/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `43.64% <37.34%> (-1.43%)` | :arrow_down: | | [dids](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/239/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `89.91% <80.00%> (+0.20%)` | :arrow_up: | | [common](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/239/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `69.44% <ø> (ø)` | |