Eliminating use of Curve and Algorithm from nimbusds dependency and instead using our own enums JwaCurve and Jwa, respectively. Adopting use of AlgorithmId which is a combination of JwaCurve and Jwa.
This PR is the first step to remove dependency on the nimbusds library and preventing exposing their types through our public API surface.
Description
Impact
Changes to many method signatures in crypto and dids package. Mostly requiring passing in of AlgorithmId instead of nimbus Algorithm and nimbus Curve.
Follow up tasks
Roll our own enums for JWK as well as various nimbus methods we still use internally, and completely remove nimbusds dependency
How Has This Been Tested?
Unit tests have been fixed to align with the new public API surface. No implementation change happened.
Checklist
Before submitting this PR, please make sure:
[x] I have read the CONTRIBUTING document.
[x] My code is consistent with the rest of the project
[x] I have tagged the relevant reviewers and/or interested parties
[x] I have updated the READMEs and other documentation of affected packages
Overview
Eliminating use of
Curve
andAlgorithm
fromnimbusds
dependency and instead using our own enumsJwaCurve
andJwa
, respectively. Adopting use ofAlgorithmId
which is a combination ofJwaCurve
andJwa
.This PR is the first step to remove dependency on the nimbusds library and preventing exposing their types through our public API surface.
Description
Impact
AlgorithmId
instead of nimbus Algorithm and nimbus Curve.Follow up tasks
How Has This Been Tested?
Checklist
Before submitting this PR, please make sure:
References
JWA spec