jiyoontbd commented 7 months ago

Overview

Introducing our own types for DID and related things like DIDDocument, Service, VerificationMethod, etc, and ejecting from did-common-java dependency. Some refactoring of DidDht implementation.

Blocked from merging by updates to web5-spec test vectors that also changed https://github.com/TBD54566975/web5-spec/pull/118

Description

Motivation (per original issue)

Not published to maven central. consumers have to add danubetech's repository

introduces CVEs (though this may have been remedied in more recent versions)

heavy on JSON-LD

Follow up tasks

Rename Did abstract class to BearerDid

[!NOTE] DidUri name in this PR is temporary - will be changed back to Did after above renaming. See https://github.com/TBD54566975/web5-kt/issues/254

Refactor DidDht

How Has This Been Tested?

Wrote tests for newly added types such as DIDDocument
Ensured all existing tests pass

Checklist

Before submitting this PR, please make sure:

[x] I have read the CONTRIBUTING document.
[x] My code is consistent with the rest of the project
[x] I have tagged the relevant reviewers and/or interested parties
[x] I have updated the READMEs and other documentation of affected packages

References

https://www.w3.org/TR/did-core/ https://github.com/TBD54566975/web5-go/tree/main/dids

jiyoontbd commented 7 months ago

blocker: need to merge https://github.com/TBD54566975/web5-spec/pull/118 and pull in latest

codecov[bot] commented 7 months ago

Codecov Report

Merging #248 (3b05af9) into main (99f9f60) will decrease coverage by 3.84%. The diff coverage is 83.12%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #248 +/- ## ========================================== - Coverage 79.62% 75.78% -3.84% ========================================== Files 38 43 +5 Lines 2189 1900 -289 Branches 316 342 +26 ========================================== - Hits 1743 1440 -303 - Misses 311 313 +2 - Partials 135 147 +12 ``` | [Components](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/248/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | Coverage Δ | | |---|---|---| | [credentials](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `81.00% <53.84%> (-1.15%)` | :arrow_down: | | [crypto](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `44.11% <ø> (ø)` | | | [dids](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `86.54% <86.75%> (-3.48%)` | :arrow_down: | | [common](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/248/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `66.29% <0.00%> (-2.67%)` | :arrow_down: |

TBD54566975 / web5-kt

Removing `did-common-java` dependency #248