TBD54566975 / web5-kt

Apache License 2.0

8 stars 9 forks source link

Implementing BearerDid / PortableDid, exposing our own JWS, JWT, JWK types #262

Closed jiyoontbd closed 3 months ago

jiyoontbd commented 4 months ago

Motivation

Align public API surface of DID creation and credential signing to be consistent with other web5 repos

Overview

BearerDid and PortableDid types used in place of Did(uri, keyManager) abstract class. Now all existing DID implementations' DidXyz.create() to return BearerDid.
Our own Jws, Jwt, Jwk types are used in place of nimbusds types. We are still creating private key internally using nimbusds (see Ed25519.kt for example), but all public surface APIs no longer expose the third party dependency.

How Has This Been Tested?

Ensured existing tests compiled and passed
Wrote new tests for new types and methods

Checklist

Before submitting this PR, please make sure:

[x] I have read the CONTRIBUTING document.
[x] My code is consistent with the rest of the project
[x] I have tagged the relevant reviewers and/or interested parties
[x] I have updated the READMEs and other documentation of affected packages

jiyoontbd commented 3 months ago

a reminder to myself to first merge https://github.com/TBD54566975/web5-spec/pull/130 and then change the submodule commit to the merge commit

also do the same for https://github.com/TBD54566975/web5-js/pull/466