search

TBD54566975 / web5-kt

Apache License 2.0
7 stars 9 forks source link

making vc type nullable during VerifiableCredential.Create() #321

Closed jiyoontbd closed 1 week ago

jiyoontbd commented 2 weeks ago

Overview

closes #320

Description

made type nullable when creating a vc via VerifiableCredential.create()

How Has This Been Tested?

i wrote a test that makes sure the vc created with null type still has the default type of VerifiableCredential and the vcDataModel's type array has 1 item ["VerifiableCredential"]

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.60%. Comparing base (fb1f9aa) to head (8ad1df2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #321 +/- ## ========================================== + Coverage 73.58% 73.60% +0.01% ========================================== Files 45 45 Lines 2162 2163 +1 Branches 402 402 ========================================== + Hits 1591 1592 +1 Misses 376 376 Partials 195 195 ``` | [Components](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/321/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | Coverage Δ | | |---|---|---| | [credentials](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/321/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `81.31% <100.00%> (+0.03%)` | :arrow_up: | | [crypto](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/321/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `49.16% <ø> (ø)` | | | [dids](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/321/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `80.50% <ø> (ø)` | | | [common](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/321/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `65.21% <ø> (ø)` | |