Closed mistermoe closed 1 week ago
Will address when deps merged/closed:
@mistermoe Just this AwsKeyManager
impl or also the InMemoryKeyManager
and other base interfaces like KeyManager
, which live in crypto
module?
@ALRubinger just AwsKeyManager
. InMemoryKeyManager
is used as the default key manager if one isn't provided during did creation
PR and open questions in #327 @mistermoe
Closed via PR #327
Currently,
AwsKeyManager
lives inweb5-crypto
module which happens to be the foundation of all other web5 modules.AwsKeyManager
relies onaws-java-sdk-kms
as a dependency which results inweb5-crypto
's dependency tree to look like this:we should move
AwsKeyManager
to its own module to reduce the dependency tree depth here. Further, theweb5
"rollup" shouldn't include theaws-key-manager
module. it can be pulled in if/as needed.Doing so will remove this portion of the dependency tree:
the depth here may not seem steep but the transitive deps here show up in almost every java project in one way or another and typically end up being the cause of dependency collisions