search

TBD54566975 / web5-kt

Apache License 2.0
10 stars 10 forks source link

Issue #323: Enforce jackson-dataformat-cbor to aligned version #326

Closed ALRubinger closed 3 months ago

ALRubinger commented 3 months ago

Addresses #323

ALRubinger commented 3 months ago

Needed to add dependencyManagement for both jackson-dataformat-cbor and jackson-dataformat-yaml.

Proof all are aligned in com.fasterxml.jackson.databind:

$> mvn dependency:tree -Dincludes=com.fasterxml.jackson.dataformat
...
[INFO] xyz.block:web5-credentials:jar:0.0.0-main-SNAPSHOT
[INFO] +- xyz.block:web5-crypto:jar:0.0.0-main-SNAPSHOT:compile
[INFO] |  \- com.amazonaws:aws-java-sdk-kms:jar:1.12.668:compile
[INFO] |     \- com.amazonaws:aws-java-sdk-core:jar:1.12.668:compile
[INFO] |        \- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.17.0:compile
[INFO] \- com.networknt:json-schema-validator:jar:1.0.87:compile
[INFO]    \- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.17.0:compile
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.60%. Comparing base (489ca78) to head (9ac4210).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #326 +/- ## ======================================= Coverage 73.60% 73.60% ======================================= Files 45 45 Lines 2163 2163 Branches 402 402 ======================================= Hits 1592 1592 Misses 376 376 Partials 195 195 ``` | [Components](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/326/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | Coverage Δ | | |---|---|---| | [credentials](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/326/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `81.31% <ø> (ø)` | | | [crypto](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/326/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `49.16% <ø> (ø)` | | | [dids](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/326/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `80.50% <ø> (ø)` | | | [common](https://app.codecov.io/gh/TBD54566975/web5-kt/pull/326/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBD54566975) | `65.21% <ø> (ø)` | |