TBD54566975 / web5-kt

Apache License 2.0
7 stars 9 forks source link

Enable tests for `AwsKeyManager` and remove `skip` on `keymanager-aws` `kover-maven-plugin` config #328

Open ALRubinger opened 1 week ago

ALRubinger commented 1 week ago

In #322 we broke out the AwsKeyManager implementation and its test suite into its own module, web5-keymanager-aws.

This breaks the build in that new module, inheriting the coverage plugin's enforcement. Because all existing tests are marked as @Disabled, there is no coverage for the module.

To unlock the work in #322, we elected to move forward by disabling the kover-maven-plugin enforcement constraint, opting to enable the tests and re-add coverage enforcement later. That discussion is In PR #327.

This issue is the "later" cleanup task. :)

        <plugin>
          <groupId>io.github.martinvisser</groupId>
          <artifactId>kover-maven-plugin</artifactId>
          <configuration>
            <!-- We temporarily disable coverage enforcement until we have tests working for this module -->
            <skip>true</skip>
          </configuration>
        </plugin>