TBD54566975 / web5-rs

Core components of the Web5 platform
Apache License 2.0
19 stars 16 forks source link

(Feature): Add ability to pass in additional-properties in Web5 CLI to `web5 vc create` #326

Closed blackgirlbytes closed 2 weeks ago

blackgirlbytes commented 2 months ago

πŸš€ Goal

Enhance the web5 vc create command to allow users to pass in additional properties when creating a Verifiable Credential.

πŸ”‘ Tasks

🌟 Resources

Getting Started

  1. Comment ".take" on this issue to get assigned
  2. Fork the repository and create a new branch for this task
  3. Implement the feature as described in the tasks
  4. Submit a pull request with your changes
  5. Respond to any feedback during the review process

πŸ’­ Questions?

If you have any questions or need clarification, please comment on this issue or join our Discord community. Happy coding! πŸŽ‰

aruokhai commented 1 month ago

.take

aruokhai commented 1 month ago

For the First task, i thought about the first approach but it seams to requires lots of typing which increases the chances for errors. Nevertheless, its ease of use is much appreciated when compared to a config file, which has a requirement of passing a correct file path, but can improve the speed of passing lots of additional parameters.

Therefore i have settled on an approach that makes use of the best of both worlds:

web5 vc create rizel \
  --portable-did $PORTABLE_DID \
  --issuer "did:dht:pe45oj88hq9zza3cjd41r5rej9ekfg9bq7k4jjeaw889t78jesko" \
  --expiration-date "2025-12-31T23:59:59Z" \
  --x-role "engineer" \
  --x-clearance "level5"
  --x "./path-to-env"

Precedence: Key-Value > Env File

blackgirlbytes commented 1 month ago

Hi @aruokhai,

Your initial .take command didn't assign the issue to you because you edited your comment. If you're still interested in working on this issue, please follow these steps:

  1. Write a new comment on the issue.
  2. Include the keyword .take in your new comment.

Once you do this, the issue should be assigned to you, and you can start working on it.

Let me know if you need any further clarification!

github-actions[bot] commented 1 month ago

Thanks for taking this issue! Let us know if you have any questions!

taniashiba commented 1 month ago

Hi @aruokhai - wanted to check back and see if you had any questions or needed help ❀

w3irdrobot commented 4 weeks ago

i can pick it up if @aruokhai is unable to complete it.

blackgirlbytes commented 4 weeks ago

I'll reassign it to you since I know you just worked on the presentation definition part of the web5 cli so you may be familiar with this. @w3irdrobot

@aruokhai I can help you find more related issues if you're interested!