search

TBD54566975 / web5-spec

Web5 Spec
https://tbd54566975.github.io/web5-spec/
Apache License 2.0
7 stars 5 forks source link

New select_credentials.json vector that has multiple Fields in one Input Descriptor #159

Closed tomdaffurn closed 1 month ago

tomdaffurn commented 3 months ago

Closes #158

Important!

Make sure that if you are updating a test vector that you test in the following repos before merging!

nitro-neal commented 3 months ago

The updated PEX lib in js expects type to be there.

export interface FilterV2 {
    const?: OneOfNumberStringBoolean;
    enum?: Array<OneOfNumberStringBoolean>;
    exclusiveMinimum?: OneOfNumberString;
    exclusiveMaximum?: OneOfNumberString;
    format?: string;
    formatMaximum?: string;
    formatMinimum?: string;
    formatExclusiveMaximum?: string;
    formatExclusiveMinimum?: string;
    minLength?: number;
    maxLength?: number;
    minimum?: OneOfNumberString;
    maximum?: OneOfNumberString;
    not?: object;
    pattern?: string;
    type: string;
    contains?: FilterV2Base;
    items?: FilterV2BaseItems;
}

Chad said type is not mandatory for valid json schema, but highly recommend. And our pex lib implementers seem to think so as well since the only required field they put was type.

So currently this change breaks js unless we add 'type' to the filter

nitro-neal commented 3 months ago

this one would have to change and have type added too - https://github.com/TBD54566975/web5-spec/pull/159/files#diff-1197e3053282a8f67310a45ce5e2675a5630f3c13291c86c5a2b88928c2d6f35R249

tomdaffurn commented 2 months ago

I'm checking each language before I merge this. It's slow because some SDKs were using old versions of the test vectors, and do not pass with the pre-existing tests. web5-kt in particular @nitro-neal.

decentralgabe commented 1 month ago

@tomdaffurn can this be merged?

tomdaffurn commented 1 month ago

@decentralgabe I think so. I was waiting to get each language SDK fixed, but I don't think we need to. They're pinned to a particular commit