TBD54566975 / web5-spec

https://tbd54566975.github.io/sdk-report-runner/
Apache License 2.0
6 stars 6 forks source link

add buildkite upload #68

Closed finn-tbd closed 7 months ago

finn-tbd commented 7 months ago

and re-arranged some stuff:

andresuribe87 commented 7 months ago

@finn-tbd just wanted to make sure you didn't miss https://github.com/TBD54566975/sdk-development/pull/68#pullrequestreview-1751550533

tl;dr; should all the code in here be tested? Apologies if it's being tested already and I missed it.

Otherwise this lgtm

finn-tbd commented 7 months ago

@andresuribe87 this is all tested, most of it in the branch's CI:

edit: unless you're talking about more automated correctness verification like unit tests or something. I don't feel those are necessary right now, especially with the desire to increase our velocity, but if others disagree I'm open to looking at ways to unit test the templates.

andresuribe87 commented 7 months ago

edit: unless you're talking about more automated correctness verification like unit tests or something. I don't feel those are necessary right now, especially with the desire to increase our velocity, but if others disagree I'm open to looking at ways to unit test the templates.

I was talking about those automated tests. I'd expect things to be really easy to test if you already have samples. I would argue not having them decreases our velocity in the medium term, as modifications to anything in the upload pipeline will be hard to verify.