TBD54566975 / web5-spec

Web5 Spec
https://tbd54566975.github.io/web5-spec/
Apache License 2.0
7 stars 5 forks source link

Replace JsonWebKey2020 with JsonWebKey #73

Open decentralgabe opened 10 months ago

decentralgabe commented 10 months ago

JsonWebKey2020 is deprecated, as it was published as a part of a now-defunct CCG draft here. It has been replaced with the recommendation-track JsonWebKey defined in vc-jose-cose.

We should replace all instances of JsonWebKey2020 in code, test vectors, docs, etc. with JsonWebKey.

mistermoe commented 9 months ago

@decentralgabe what timeframe do you think makes sense for a change like this? should we prioritize it in your opinion?

decentralgabe commented 9 months ago

I would wait until https://w3c.github.io/vc-jose-cose/ is in Candidate Recommendation. I will report back here when that happens. Hopefully within a month or so.

mistermoe commented 9 months ago

nitro-neal commented 8 months ago
image

It may turn into non trivial changeif there are significant changes to JsonWebKey2020 and the new one right?

https://w3c.github.io/vc-jose-cose/#verification-methods

At first glance it looks like there are some differences

decentralgabe commented 8 months ago

@mistermoe what differences do you see? It should be a drop in replacement

mistermoe commented 8 months ago

@decentralgabe I think the above comment was intended for @nitro-neal ?

decentralgabe commented 8 months ago

Oops yup

mistermoe commented 8 months ago

@nitro-neal ^

nitro-neal commented 8 months ago

In searching for instances of JsonWebKey2020 in our codebase in kt I only found this in the didIon.kt but yea it seems like it does not conform.

image
decentralgabe commented 8 months ago

that all seems right @nitro-neal

nitro-neal commented 8 months ago

web5-spec - https://github.com/TBD54566975/web5-spec/pull/113 web5-kt - https://github.com/TBD54566975/web5-kt/pull/220

decentralgabe commented 1 month ago

What is the status on this today? Do we support both types everywhere? Just one?