search

TBK / MusicBot

MusicBot for Discord - Docker edition
https://hub.docker.com/r/discordmusicbot/
MIT License
14 stars 3 forks source link

GrantToRoles not working #16

Open Fonta opened 7 years ago

Fonta commented 7 years ago

Heya,

Awesome to see someone still making progress on this bot.

I'm running into a problem though. Somehow users don't get the rights they should get when they have a role. in my config I have this:

; This group has full permissions.
[MusicMaster]
GrantToRoles = 126272553265135616 126272446419566593 126272553265135616
; UserList =
MaxSongLength = 0
MaxSongs = 0
MaxPlaylistLength = 0
AllowPlaylists = yes
InstaSkip = yes
AllowHigherVolume = yes

But the user gets this:

name: Default
command_whitelist: {'queue', 'perms', 'search', 'play', 'skip', 'id', 'clean', 'help', 'np'}
ignore_non_voice: {'skip', 'search', 'play'}
max_songs: 0
max_song_length: 1200
max_playlist_length: 0
allow_playlists: True
instaskip: False
allow_higher_volume: False

Do you know what is going wrong?

TBK commented 7 years ago

Thanks :)

I will run some tests later tonight.

Fonta commented 7 years ago

Created a PR for this one too. https://github.com/DiscordMusicBot/MusicBot/pull/20 I'm not really familiair with Python so I don't know why isinstance doesn't work.

TBK commented 7 years ago

Do you run the bot via Docker or "natively"?

Fonta commented 7 years ago

via docker.

TBK commented 7 years ago

:( my dev pc just went belly up so I will not be able to provide a fix tonight.

I think the issue is related to incorrect matching between the group definition in permissions.ini file and the Discord group.

Fonta commented 7 years ago

Well, everything works just fine with the in the PR suggested change.

Fonta commented 7 years ago

Not sure why you closed the PR, but you probably have a good reason for it. I'll delete the branch.