search

TBK / MusicBot

MusicBot for Discord - Docker edition
https://hub.docker.com/r/discordmusicbot/
MIT License
14 stars 3 forks source link

Youtube Livestreams half functional #25

Open Project-Aurora opened 7 years ago

Project-Aurora commented 7 years ago

When queueing a Livestream as if it was a normal Video, the Sound actually plays while throwing a long exception that eventually leads to: AttributeError: 'StreamPlaylistEntry' object has no attribute 'start_seconds' However, this doesn't seem to interfere with the programs Function.

During Playback, these two lines are thrown over and over again, the timing coincides with the Stuttering. [tls @ 0xblablabla] The TLS connection was non-properly terminated. [tls @ 0xblablabla] The specified session has been invalidated for some reason. (the blabla part changing every time)

When skipping the "Video", deleting the File doesn't seem to work. [ERROR:player] Error trying to delete https://manifest.googlevideo.com/api/manifest/hls_playlist/id/L5WSBZp7LrQ.0/itag/95/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/cmbypass/yes/goi/160/sgoap/gir%3Dyes%3Bitag%3D140/sgovp/gir%3Dyes%3Bitag%3D136/hls_chunk_host/r1---sn-xjpm-q0nl.googlevideo.com/ei/W1-wWeTGMda31gKWpaKYBg/gcr/de/playlist_type/DVR/mm/32/mn/sn-xjpm-q0nl/ms/lv/mv/m/pl/17/dover/6/mt/1504730605/ip/91.64.78.123/ipbits/0/expire/1504752571/sparams/ip,ipbits,expire,id,itag,source,requiressl,ratebypass,live,cmbypass,goi,sgoap,sgovp,hls_chunk_host,ei,gcr,playlist_type,mm,mn,ms,mv,pl/signature/2CF300A7D568C666F93FA3D27AD2FC86FDE312A0.3BA3220229BCB0D97D308FF2CDF2035AE3D935CD/key/dg_yt0/playlist/index.m3u8 Traceback (most recent call last): File "/home/user/MusicBot-1.9.9/musicbot/player.py", line 316, in _delete_file os.unlink(filename) FileNotFoundError: [Errno 2] No such file or directory: 'https://manifest.googlevideo.com/api/manifest/hls_playlist/id/L5WSBZp7LrQ.0/itag/95/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/cmbypass/yes/goi/160/sgoap/gir%3Dyes%3Bitag%3D140/sgovp/gir%3Dyes%3Bitag%3D136/hls_chunk_host/r1---sn-xjpm-q0nl.googlevideo.com/ei/W1-wWeTGMda31gKWpaKYBg/gcr/de/playlist_type/DVR/mm/32/mn/sn-xjpm-q0nl/ms/lv/mv/m/pl/17/dover/6/mt/1504730605/ip/91.64.78.123/ipbits/0/expire/1504752571/sparams/ip,ipbits,expire,id,itag,source,requiressl,ratebypass,live,cmbypass,goi,sgoap,sgovp,hls_chunk_host,ei,gcr,playlist_type,mm,mn,ms,mv,pl/signature/2CF300A7D568C666F93FA3D27AD2FC86FDE312A0.3BA3220229BCB0D97D308FF2CDF2035AE3D935CD/key/dg_yt0/playlist/index.m3u8' I didn't test what happens when a Stream ends naturally.

I'm using the 1.9.9 Release on Debian x64 I can give you more specific Information if you ask for it. You can find Streams here.

Not sure how much Work it will take to fix these Issues, maybe stopping People from adding Livestreams is preferrable to you.

TBK commented 6 years ago

It is also flawed in the original Just... version.

Did you use the play or stream command?

The whole play/queue code is a tangled mess. I intent to rewrite the bot from scratch, but it won't be any time soon since school and other OSS projects take up my time.

Project-Aurora commented 6 years ago

The "stream" command gives the same results. While trying to diagnose the underlying issue, I noticed the absurd complexity of the Code as well. When you do rewrite it, will you stick with Python or use a different language?

TBK commented 6 years ago

I intent to write it in either Go or Rust.

Fonta commented 6 years ago

Didn't try in the original version. Could indeed be flawed. Guess that the play command tries to download the stream which is kinda impossible, so I probably used the stream command. Curious what you'll create of it when you completely rewrite the bot from scratch!