search

TBMCPlugins / PluginConfigs

This repository contains all the config files for the currently loaded plugins.
GNU General Public License v3.0
0 stars 1 forks source link

Towny Withdraw Perms not honoured #36

Closed Gryph667 closed 6 years ago

Gryph667 commented 6 years ago

Describe the bug Town and nation members are allowed to /t withdraw XXX and /n withdraw despite not having the permissions for those commands. Towns and nations have to be able to set rents and taxes that aren't immediately refunded without the group leader's knowledge.

To Reproduce Steps to reproduce the behavior:

  1. Confirm in TownyPermissions file that only mayors have towny.command.town.* which includes the Withdraw command
  2. Confirm in TownyPermissions file that only kings have towny.command.nation.* which includes the withdraw command
  3. Confirm there is no reference to "towny.command.town.withdraw" or "towny.command.nation.withdraw" anywhere in the same file that would explicitly grant the permission
  4. Log into a non king/non mayor that is a member of a town and/or nation
  5. Execute the /t withdraw 2 and/or /n withdraw 2 commands

Expected behavior Person should get an error saying they aren't allowed to grab the cash

Actual Results User gets the cash they are supposed to be blocked from accessing.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

NorbiPeti commented 6 years ago

Fixed in #38 and fixed again in d40e40b.