TBS-EACPD / infobase

Source code for GC InfoBase / Code source de l'InfoBase du GC
https://canada.ca/GCInfoBase
Other
29 stars 5 forks source link

Stop flat-lining Mains as a stand in for planned spending from non-DP orgs #1599

Open Stephen-ONeil opened 2 years ago

Stephen-ONeil commented 2 years ago

The flat-lining of estimates as a stand in for planned spending from non-DP orgs is an old practice now, I think done since InfoBase first began publishing planned spending. It is explained on the site via the following footnote:

Planned expenditures for most organizations are sourced from Departmental Plans. Where Planned Spending information is not available (notably for Parliamentary Entities, the Office of the Governor General's Secretary, the Canadian Security Intelligence Service, the Communication Security Establishment, the International Joint Commission (Canadian Section) and most Crown Corporations), for illustrative purposes only, GC InfoBase presents the most recent Main Estimates figures for these organizations as being constant across the three planning years.

I don't think this decision was made by any current team members, and the consensus with the present team is that this is something we would like to stop doing.

In practice, the flat-lining of mains occurs in the program spending dataset itself, upstream. Questionable nature of the practice aside, this implementation has always been a persistent source of bugs. I think it was intended that the flat-lined Mains values would contribute to the government level roll up of planned spending, and maybe appear in the report builder so that the totals matched (and maybe so that the flat-lined cases could be seen directly). Otherwise they weren't supposed to be presented in the org, CR, and program infographics. This meant everyone had to know about and write a check to identify and ignore the fake planned spending data whenever it was used... this has not always been done/done consistently (E.g. this program is displaying flat-lined planned spending in it's CR level infographic, but the relevant org level infographic has no planned information).

Side note, I've never actually known where the program level authorities for this come from. We don't otherwise publish authorities at the program level.

Putting this practice to rest will look something like this:

nhamalainen-tbs commented 2 years ago

CR level authorities (not program) are from Expenditures by Purpose, published with main estimates (https://www.canada.ca/en/treasury-board-secretariat/services/planned-government-spending/government-expenditure-plan-main-estimates/2022-23-estimates/expenditures-purpose.html). The pipeline sources them from the Bluebooksbycoreresponsibility cube in the data warehouse.

vseeto commented 2 years ago

As far as I understand, we cannot publish no program level authorities as they do not exist. The Estimates provide authorities as the CR level only. CFMRS collects expenditures at the program level which can be rolled up to CRs through the EA data warehouse.

Are "in-year estimates" authorities? If yes, keep in the gov level.

Agree with the optional follow up of splitting the actual and planned datasets. I suggest we discuss the option of separating FTE and financial data so that PA does not need DRR FTE data which is already issue "Consider decoupling program FTE resources from Spending resources TBS-EACPD/infobase#1602".

Stephen-ONeil commented 2 years ago

CR level authorities (not program) are from Expenditures by Purpose, published with main estimates...

As far as I understand, we cannot publish no program level authorities as they do not exist. The Estimates provide authorities as the CR level only. CFMRS collects expenditures at the program level which can be rolled up to CRs through the EA data warehouse.

Right, that's why I forgot about this, flat-lined mains for non-DP orgs are part of the "fake program" problem. By default (there may still be an exception or two, e.g. FCAC being quasi-DP), non-DP orgs do not actually have programs. Since they do have CRs, their CR data is counted in the program level datasets for alignment purposes. To do this, their CR data is attributed to a fictitious child program under each CR (same name as that CR, InfoBase redirects to that CR's infographic if trying to visit the fictitious program). My confusion was how authorities were apparently being split down to the program level, but they aren't because flat-lining is only being done for fake programs (actually CRs).

Are "in-year estimates" authorities? If yes, keep in the gov level.

Yes, I meant the authorities coming from the current year, where, most likely, further supplementary estimates are expected and the authorities aren't final.