Closed HSenarath closed 1 month ago
Attention: Patch coverage is 0%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 7.06%. Comparing base (
0243395
) to head (e39f78c
). Report is 2 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
...lient/src/components/DisplayTable/DisplayTable.tsx | 0.00% | 11 Missing :warning: |
client/src/rpb/granular_view.js | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Was trying to do too much in one PR, so simplified the tasks to:
type: "dollar"
, currently it's set as "big_int
so it's missing the '$' in the table which is inconsistent with the rest of the spending rows-
value instead of 'Not Applicable'
'-'
values in the rpb
Follow up to #1592
To Do:
Crown corps were given 'Not Applicable' value in RPB, but this is breaking the sort function because the columns now have both a string and number to sort. Fix the sort function to be able to handle 'Not Applicable' cases.TableClass
we gave any“.”, “”, “-”
a value of zero so it doesn’t break other functionalities such as summing the column values of a csvIn the future, instead of retroactively removing the pipeline generated planned spending values for crown corps maybe the pipeline shouldn’t generate these values in the first place.