TBS-EACPD / infobase

Source code for GC InfoBase / Code source de l'InfoBase du GC
https://canada.ca/GCInfoBase
Other
29 stars 5 forks source link

Fix RPB sort function for 'Not Applicable' cases #1621

Closed HSenarath closed 1 month ago

HSenarath commented 4 months ago

Follow up to #1592

To Do:

In the future, instead of retroactively removing the pipeline generated planned spending values for crown corps maybe the pipeline shouldn’t generate these values in the first place.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 7.06%. Comparing base (0243395) to head (e39f78c). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...lient/src/components/DisplayTable/DisplayTable.tsx 0.00% 11 Missing :warning:
client/src/rpb/granular_view.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1621 +/- ## ========================================= - Coverage 7.07% 7.06% -0.01% ========================================= Files 395 395 Lines 14435 14442 +7 Branches 3584 3589 +5 ========================================= Hits 1021 1021 - Misses 13414 13421 +7 ``` | [Flag](https://app.codecov.io/gh/TBS-EACPD/infobase/pull/1621/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBS-EACPD) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/TBS-EACPD/infobase/pull/1621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBS-EACPD) | `3.10% <0.00%> (-0.01%)` | :arrow_down: | | [form_backend](https://app.codecov.io/gh/TBS-EACPD/infobase/pull/1621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBS-EACPD) | `87.85% <ø> (ø)` | | | [server](https://app.codecov.io/gh/TBS-EACPD/infobase/pull/1621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBS-EACPD) | `33.91% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TBS-EACPD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HSenarath commented 1 month ago

Was trying to do too much in one PR, so simplified the tasks to: