TBS1996 / TaleCast

Simple CLI podcatcher
MIT License
61 stars 7 forks source link

Error 'failed to rename episode' for certain episodes in 20 #11

Closed rahimnathwani closed 4 months ago

rahimnathwani commented 4 months ago

Thank you for making Talecast. I was looking for something similar to castget yesterday. I searched on HN search, and found Talecast :)

When I try to download the 20VC podcast, the most recent 9 episodes download correctly. But the 10th most recent (at the time of writing) won't download.

This is the content of the .downloaded file:

1256765b-e7a2-41b3-b2f9-8bf393082cfa 1716137975 "20Product: How Linktree, Webflow and Airbnb Used Rituals and Product Principals to Guide Product Roadmap, Why All Product Teams Should Have a Scorecard and How to Use it & How to Run the Best "Product Jams" with JZ, CPO @ Linktree"
76ebe415-ea78-441f-8d3e-f74e367b6444 1716137980 "20VC: Fundraising Wisdom that is Total BS; Dilution, Meeting Associates, Taking the Highest Price, Always Be Raising | Why Second Time Founders Are More Investable & Why Not To Hire People Out of College with Dan Siroker, CEO @ Limitless"
fa63d829-3471-4e7f-b2c4-b269bf4fbfcb 1716137984 "20VC: Behind the Scenes at Y Combinator: The Interview Process | What the Best & Worst Do in the Program | Do the Best All Raise Pre-Demo Day & YC's Fundraising Advice to Startups | Why the Value is in Application Layer AI with Tom Blomfield"
97b27f2d-b818-48e8-8422-aac51c3c73f0 1716137989 "20Sales: How to Build Vertical Sales Teams, Why No Customer Success is BS and Everyone Needs it, How to Hire, Train and Retain the First Reps and Lessons Scaling to $2.1BN Revenue and 1,300 People with Larry Schurtz, CRO @ Genesys"
a4aa893d-423a-4686-9f64-9f7554ba6d54 1716137994 "20VC: GV's Tom Hulme on Why Investing in Foundation Models is like Investing in "Power Stations", The Conventional Wisdom in VC that is BS & Lessons from a 24x Angel Track Record, 255x on Robinhood and Making Billions on Uber"
ce55c0fb-5205-49b2-a3c3-d27b9d56f391 1716137998 "20VC: Benchmark's Sarah Tavel on Are Foundation Models Commoditising | Why Frontier Models Will Be Closed Source | Why the Value is in the Application Layer | The Future of AI is "Selling the Work" Not the Tools"
09cd3387-4443-4aea-80b2-ada9aa6880e8 1716138000 "20VC: The Memo: Keith Rabois and Ramp's Eric Glyman on Behind The Scenes at The Best Run Private Company on the Planet; The Tools, Tips, Secrets and Process That Drive Efficiency"
86f9b9b6-50e9-4116-9f2b-fe3899cfa04b 1716138004 "20VC: Mark Suster on The Biggest Fundraising Lessons for VCs, Why the Correction in Venture is Still to Come, Why Private Equity Will Replace IPOs and M&A as the Exit Path & The Woke Left and a Trump Administration; What Happens?"
6298c84d-d97c-411c-aefd-122100451451 1716138007 "20VC: Mistral's Arthur Mensch: Are Foundation Models Commoditising | How Do We Solve the Problem of Compute | Is There Value in the Application Layer | Open vs Closed: Who Wins and Mistral's Position"

The title of the next most recent episode (from the RSS file) is:

<title>20Growth: Inside Dropbox, Salesforce &amp; Heroku's Product-Led Growth Engine; What Works &amp; What Doesn't | Why Startups Doing Paid Under $100M ARR are not PLG | Why PLG is a Business Model, Not a Go-To-Market Motion with Adam Gross, Former CEO @ Vimeo</title>

I thought this might be due to some special character the code doesn't handle well, but there are other episodes with ampersands, pipes, semi-colons, dollar signs etc., that have downloaded just fine.

talecast-20vc

TBS1996 commented 4 months ago

Hi, thank you so much for the detailed write-up! and I'm glad you find my program useful.

I identified the bug and ive published the fix, so if you update, it should work.

The problem was I sanitized the filename, then added the extension. So if the title was too long, sanitizing truncated it to 255 bytes, but then adding the extension caused it to go over the limit and the rename operation would fail.

hope itll work on your end, if you have any other feedback, please post it ^^

rahimnathwani commented 4 months ago

Thank you! It works!