search

TBSniller / piccap

PicCap - Hyperion Sender App | Ambilight for LG WebOS TVs
MIT License
296 stars 30 forks source link

PicCap using native hyperion-webos service #18

Closed TBSniller closed 2 years ago

TBSniller commented 2 years ago

We have updated hyperion-webos to be a native service. The nodeJS-service isn't needed anymore. Updated hyperion-webos Merged impressions from @Informatic Fixed up UI

@Informatic: Could you please take a look at this? Thanks!

TBSniller commented 2 years ago

@Informatic Would you like to check again? Thanks!

TBSniller commented 2 years ago

There is also a little "bug" in autostart. Haven't exited in the autostart script, that's possibly why dev-mode script is failing and failback mode is activated after second restart. Will fix it.

Informatic commented 2 years ago

That's definitely a bug in service implementation, and definitely should be fixed there (though I couldn't reproduce it here?)

Does it actually start up the service in that case, and just not send a reply? I think a call should return with an error anyways, if a backing service just crashes mid-request.

TBSniller commented 2 years ago

Yeah it starts up, but after a normal reboot it has entered failsafe mode and I had to disable it. It looked like: Boot -> autostart PicCap -> reboot -> Failsafe -> disable failsafe -> reboot -> autostart PicCap -> reboot -> failsafe -> ....

Edited the script, until now two restarts and everything went well. Will take a look the next days

Informatic commented 2 years ago

Sure, but this will also leave dangling luna-send execution in the background. I think we should probably rather use timeout or something similar, if we really weren't able to resolve it service-side.

TBSniller commented 2 years ago

Waiting on some tests here: https://github.com/TBSniller/piccap/releases/tag/0.2.1

TBSniller commented 2 years ago

Final tests done