search

TBartl / space-station-13-idle

GNU Affero General Public License v3.0
42 stars 32 forks source link

New setting to show underlines on actions that haven't been completed #431

Closed PKPenguin321 closed 2 years ago

PKPenguin321 commented 2 years ago

When this setting is enabled, actions that have items that you don't yet have completion marks for in your Completion page in their output will display a subtle underline. image In the above image, I haven't ever acquired a Nuka Cola or a Gargle Blaster on that loop, so they're underlined. As soon as I brew one (or acquire one in any way that counts for completion), the underline vanishes.

I made this a setting because it adds a few dozen operations behind the scenes to detect your item completion every time actions are reloaded which may affect performance. I don't really know a good way to benchmark this game, so I figured it would be better to be safe than sorry. It's disabled by default.

Also, it looks like we scraped the wrong trophy icon (we got the 16x16 SS13 emoji sprite instead of the 32x32 SS13 ingame sprite), so I fixed that too while I was in there.

Nabski89 commented 2 years ago

Yeah this is a good change.

PKPenguin321 commented 2 years ago

Could have done with code review first, but so far in my playtesting tonight it seems okay