TBroTeam / TBro

Visualization and management of denovo transcriptomes
https://tbroteam.github.io/TBro/
10 stars 6 forks source link

carts cannot be filled #59

Closed nterhoeven closed 3 years ago

nterhoeven commented 6 years ago

Sometimes carts can't be filled with items. The items get lost during the sync.

from the apache error log:

Maximum execution time of 30 seconds exceeded in /share/tbro/TranscriptDB/webservices/cart/Sync.php on line 180

Line 180 of this file:

$ids_context = array_intersect($parms['ids'], $results['results']);
iimog commented 6 years ago

Hi @nterhoeven thanks for reporting this. I had a look at it and it seems to happen for some organism/release combinations and not for others. Interestingly the number of features in the release that works fine is even larger than that in the release that does not work. Increasing max_execution_time to 300 is enough to make it work but the full five minutes are used. I'll have to dig a little deeper.

nterhoeven commented 6 years ago

@iimog and me took a closer look at this Problem.

The line in question is a sanity check to prevent that IDs from wrong Organism-release combinations are added to a cart. When the datasets get larger (several hundred thousand transcripts) the comparison of the two arrays is very slow.

We decided for a temporary solution The check is skipped by changing the following steps:

We should still find a better solution here, but until then, TBro is at least useable.