search

TBye101 / MagicalLife

A 2d game that aspires to be similar to Rimworld, with more depth, magic, and RPG concepts.
MIT License
235 stars 27 forks source link

Job Selection Tools #110

Open TBye101 opened 5 years ago

TBye101 commented 5 years ago

Clicking on one command type doesn't unselected the others

ABuonanni commented 5 years ago

For what I can see this behaviour isn't implement at all. So this is not a bug to find and fix but a feature to implement, right?

TBye101 commented 5 years ago

Yeah, not sure why I marked this as a bug. Must've been late or something.

ABuonanni commented 5 years ago

I'm looking at this issued and I was thinking that action buttons (Chop, Mine and TillDirt) should have a public boolean property called like "IsSelected" or "HasSelectedAspect" that the InGameGUI can use to set its buttons appeareance. The property setter code will choose the right texture for the button based on the value of InGameGUI's Selected property. Now this behaviour should be applied to all three buttons and I were wondering wheter was the case to create a new class (called something like ActionButton, to hold all common action buttons behaviour) to implements this in or to implement it in the MonoButton class (but I don't like this second option as much as the first). What do you say?

TBye101 commented 5 years ago

I like the first option, as not all buttons are toggle on/toggle off. However, I would ask you to consider making a class that extends MonoButton that implements that behavior. Then make some sort of manager class that handles only having one togglable button active at a time. What do you think of that?

Thomas

From: ABuonanni notifications@github.com Sent: Sunday, April 14, 2019 9:09:43 AM To: SneakyTactician/MagicalLife Cc: Thomas Bye; Author Subject: Re: [SneakyTactician/MagicalLife] Job Selection Tools (#110)

I'm looking at this issued and I was thinking that action buttons (Chop, Mine and TillDirt) should have a public boolean property called like "IsSelected" or "HasSelectedAspect" that the InGameGUI can use to set its buttons appeareance. The property setter code will choose the right texture for the button based on the value of InGameGUI's Selected property. Now this behaviour should be applied to all three buttons and I were wondering wheter was the case to create a new class (called something like ActionButton, to hold all common action buttons behaviour) to implements this in or to implement it in the MonoButton class (but I don't like this second option as much as the first). What do you say?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SneakyTactician/MagicalLife/issues/110#issuecomment-482984157, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQ16c3dfkVWltPRFZpp7fGOqPSGBNeNdks5vgzangaJpZM4Z9Sfo.

ABuonanni commented 5 years ago

I like the idea. I'm gonna implement a class that extends MonoButton and a class, let say "ActionButtonsManager", that handles only having one togglable button active at a time.

TBye101 commented 5 years ago

I'd recommend branching from the "crafting branch" for this, as I've moved around the GUI API to it's own assembly in that branch.

Thomas

From: ABuonanni notifications@github.com Sent: Monday, April 15, 2019 1:23:37 AM To: SneakyTactician/MagicalLife Cc: Thomas Bye; Author Subject: Re: [SneakyTactician/MagicalLife] Job Selection Tools (#110)

I like the idea. I'm gonna implement a class that extends MonoButton and a class, let say "ActionButtonsManager", that handles only having one togglable button active at a time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SneakyTactician/MagicalLife/issues/110#issuecomment-483122788, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQ16c-ZUhDT4tOi4jVlWveGSEoXPp_84ks5vhBrpgaJpZM4Z9Sfo.

ABuonanni commented 5 years ago

Ok, I'll do. Thanks.

ABuonanni commented 5 years ago

I'm resuming working on this issue. Is still Crafting the branch to work on? Thanks.

TBye101 commented 5 years ago

No, it got merged into master. I recommend working off of master.

Thomas

From: ABuonanni notifications@github.com Sent: Thursday, May 23, 2019 1:25:08 AM To: SneakyTactician/MagicalLife Cc: Thomas Bye; Author Subject: Re: [SneakyTactician/MagicalLife] Job Selection Tools (#110)

I'm resuming working on this issue. Is still Crafting the branch to work on? Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SneakyTactician/MagicalLife/issues/110?email_source=notifications&email_token=AEGXU4Y24QRKFR6CL4XKRLLPWY2EJA5CNFSM4GPVE7UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWBGGWY#issuecomment-495084379, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEGXU4ZGDVM2OVVKROGB4NTPWY2EJANCNFSM4GPVE7UA.