search

TC2013 / Roundtrip2

5 stars 36 forks source link

Need GUI to select time-zone #8

Open GeoffWyche opened 8 years ago

timomer commented 8 years ago

Would you not read this from the phone? Or does this need to be independent of the phone timezone?

GeoffWyche commented 8 years ago

Good point. The time zone is needed because Medtronic pumps do not use time zones in their timestamps. The phone's time zone should be just fine.

--G

On Sun, 2016-06-19 at 04:34 -0700, timomer wrote:

Would you not read this from the phone? Or does this need to be independent of the phone timezone?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

timomer commented 8 years ago

Right, got you.

The only issue I can see here is when a user travels across time zones, do these users update the time on their pumps? The phone will most likely update itself, this will happen without the user noticing so maybe it is best to manually set in the app.

@TC2013 what are your thoughts on this?

TC2013 commented 8 years ago

We haven't traveled using OpenAPS recently, but we used to have to set our phone not to switch time zones when traveling. I'll check with @scottleibrand because I think they actually have a better workaround. However, the pi/edison wouldn't change time, but getting BG values from NS might be affected (if the user is uploading CGM with their phone).

scottleibrand commented 8 years ago

Our loop runs clockset.sh to set the pump and CGM time to the current time on the rig if it is mismatched. If the rig doesn't have NTP sync'd, it instead sets the rig to the more recent of the pump and CGM times. A similar approach should work for you.

timomer commented 8 years ago

Cool, sounds good, so the rig will be our mobile. CGM time should be correct as that's an android app, we will just need to be sure the pumps time matches phone time.

On Mon, 20 Jun 2016, 04:02 Scott Leibrand, notifications@github.com wrote:

Our loop runs clockset.sh to set the pump and CGM time to the current time on the rig if it is mismatched. If the rig doesn't have NTP sync'd, it instead sets the rig to the more recent of the pump and CGM times. A similar approach should work for you.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TC2013/Roundtrip2/issues/8#issuecomment-227041302, or mute the thread https://github.com/notifications/unsubscribe/AE_kFKXbYBM2Gr_VjOFJYarD--tsa-KEks5qNgLZgaJpZM4Ivg8F .