Closed DanRyanIrish closed 2 months ago
Attention: Patch coverage is 16.78832%
with 114 lines
in your changes are missing coverage. Please review.
Project coverage is 26.65%. Comparing base (
d44a1c8
) to head (bd428a0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Regarding the top-level checkpoint on handling sliceable metadata, once this PR is merged into ndcube
and released, we could use ndcube.Meta
and VisMeta
included in the xrayvision Visibility PR as parent classes for a STIXVisMeta
class. We could then implement a STIXVisMeta.rebin
method that does a certain number of general, but well-defined things to the visibilities metadata on rebinning, e.g. adding the detector string labels together so we can see which detectors are included in a rebinned bin.
@samaloney Could you merge/backport #106 and #107 into the TCDSolar ndcubify branch to make the diff more readable?
To Do:
NDCube
instance, strip the data and mask, and return the rebinned data and mask arrays.gwcs
and ndcubeTableCoordinate
s from adapted coordinate valuesNDCube
type as input cube.