search

TCDSolar / stixpy

STIX data analysis in python
https://stixpy.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 20 forks source link

Update ephemeris calculations #111

Closed samaloney closed 2 months ago

samaloney commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 94.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 69.52%. Comparing base (a694ede) to head (baa1454).

Files Patch % Lines
stixpy/coordinates/transforms.py 94.66% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #111 +/- ## ========================================== + Coverage 68.92% 69.52% +0.60% ========================================== Files 31 31 Lines 1847 1887 +40 ========================================== + Hits 1273 1312 +39 - Misses 574 575 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samaloney commented 2 months ago

Thanks @FredSchuller I think in the IDL code already pulls them from a config file see below, I will update the python code to match once the file is include in STIX-CONF repo.

I'm not 100% on the signs myself but the final results match IDL 🤷 Myself and @paolomassa were chatting last week we should try to formalise the transformations can add that is the python docs a and IDL docs somewhere. There are at lest three native SAS detector coordinates which are rotated (~45 deg) + possible shifted compared the the STIX frame and this is again rotated and shifted compared to the SO HPC frame etc

https://github.com/i4Ds/STIX-GSW/blob/bb8acc8accc2ec59a9cbd6e277d4098856c34a2d/stix/idl/processing/aux_data/stx_create_auxiliary_data.pro#L179-L180

FredSchuller commented 2 months ago

Thanks @FredSchuller I think in the IDL code already pulls them from a config file see below, I will update the python code to match once the file is include in STIX-CONF repo.

Yes I know, but still there is room for improvement in the way it's implemented, because this file (Mapcenter_correction_factors.csv) is supposed to be under $STIX_SAS which is defined somewhere else. A cleaner way would be to write the values of these parameters in the primary header of the L2 aux file (they do not change with time, but may change from one version to the next of the aspect data processing) But that's a different topic...