TCDSolar / stixpy

STIX data analysis in python
https://stixpy.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 20 forks source link

CVE-2007-4559 Patch #53

Closed TrellixVulnTeam closed 1 year ago

TrellixVulnTeam commented 1 year ago

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

codecov-commenter commented 1 year ago

Codecov Report

Base: 66.95% // Head: 67.28% // Increases project coverage by +0.32% :tada:

Coverage data is based on head (139a2b1) compared to base (709bd78). Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #53 +/- ## ========================================== + Coverage 66.95% 67.28% +0.32% ========================================== Files 10 10 Lines 802 813 +11 ========================================== + Hits 537 547 +10 - Misses 265 266 +1 ``` | [Impacted Files](https://codecov.io/gh/samaloney/stixpy/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Shane+Maloney) | Coverage Δ | | |---|---|---| | [stixpy/data/test.py](https://codecov.io/gh/samaloney/stixpy/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Shane+Maloney#diff-c3RpeHB5L2RhdGEvdGVzdC5weQ==) | `93.75% <91.66%> (-1.49%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Shane+Maloney). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Shane+Maloney)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

samaloney commented 1 year ago

Nice, spot this has been closed in #58.