search

TCLProject / ArsMagica2-5

Ars Magica 2.5
15 stars 8 forks source link

Serious issue: Soulbound deletes items #51

Open Shahelion opened 4 months ago

Shahelion commented 4 months ago

The Soulbound enchant does not preserve items upon death, it destroys them completely. This also applies to items with innate Soulbound, like the arcane spellbook or the hellcow horn.

AirBurn0 commented 4 months ago

It does preserve items. But sometimes not.

I'm not sure if DrParadox7's solu is any good, cuz it simply reverts some parts of that commit, but trick can be hidden here. If entity somehow manages to skip ticks from 6 to 9, soulbound will not work (lmao).

Test version without < 10 check is here for you to test it.

Shahelion commented 4 months ago

TCL version deleted items every time. Paradox version preserved them every time. Only able to test in single player at the moment. Will test your version when I get a chance.

AirBurn0 commented 4 months ago

TCL version deleted items every time. Paradox version preserved them every time. Only able to test in single player at the moment. Will test your version when I get a chance.

It doesn't delete items for me. But you got the point, it definitely can. And, goodness gracious, even more - it is capable of duplicating item by just dropping them in 6 to 9 ticks interval, if it doesn’t delete items of course. (which I also fixed, I suppose)

Shahelion commented 4 months ago

Do you have a .jar I could use to test? Not familiar with how to get the mod from just the source code.

AirBurn0 commented 4 months ago

Here

brandyyn commented 4 months ago

Here

Hey this worked! It fixed soulbound for me on my server and singleplayer, only thing is, this doesn't include your optifine checking fix... that's fine, but you should implement this soulbound fix into the main repository, currently technoparadox's repository, also include these fixes: https://github.com/quentin452/ArsMagica2-5/releases

Lykayos commented 1 month ago

@AirBurn0 Hey, was wondering if you could help me out with an issue, couldn't think of another way to contact you. Email me at dragonmundayy@gmail.com was hoping you could help with possibly creating a fix for an AM2.5 issue

Shahelion commented 1 month ago

@AirBurn0 Hey, was wondering if you could help me out with an issue, couldn't think of another way to contact you. Email me at dragonmundayy@gmail.com was hoping you could help with possibly creating a fix for an AM2.5 issue

Just open an issue on here about the problem you're having.

Lykayos commented 1 month ago

Issue submitted

On Wed, Sep 11, 2024 at 8:10 PM Colin @.***> wrote:

@AirBurn0 https://github.com/AirBurn0 Hey, was wondering if you could help me out with an issue, couldn't think of another way to contact you. Email me at @.*** was hoping you could help with possibly creating a fix for an AM2.5 issue

Just open an issue on here about the problem you're having.

— Reply to this email directly, view it on GitHub https://github.com/TCLProject/ArsMagica2-5/issues/51#issuecomment-2345179512, or unsubscribe https://github.com/notifications/unsubscribe-auth/BLHA6NWVKXDWVZMUNOP7P6LZWEA3VAVCNFSM6AAAAABILQI2OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGE3TSNJRGI . You are receiving this because you commented.Message ID: @.***>

RubilaxXxx commented 5 days ago

fixed

RubilaxXxx commented 5 days ago

Here

doesn't work in the end/nether and i managed to dupe aswell