TCNOco / TcNo-Acc-Switcher

A Super-fast account switcher for Steam, Battle.net, Epic Games, Origin, Riot, Ubisoft and many others!
GNU General Public License v3.0
1.68k stars 122 forks source link

Incorrect ProductVersion property for Uninstall Registry Key #355

Open rakleed opened 8 months ago

rakleed commented 8 months ago

Describe the bug The ProductVersion property for Uninstall Registry Key is version 4.

To Reproduce Steps to reproduce the behavior:

  1. Install latest version of TcNo Account Switcher
  2. Open Windows 11 Settings
  3. Go to Apps, then Installed Apps
  4. Find TcNo Account Switcher in the list

Expected behavior The ProductVersion property for Uninstall Registry Key indicates the current version 5.0 - 2023-07-05_00.

Screenshots image

Desktop (please complete the following information):

Additional context

Eddga commented 8 months ago

+1 But: @rakleed in any case you commited the wrong version number in the installer yaml here: https://github.com/microsoft/winget-pkgs/pull/125068 I'm using Winget-AutoUpdate and it updated today as soon as it found the app in winget and thought that 2023-07-05_00 was bigger than 4 (which is true, but... yeah) even though I already was at that version. And now my complete TcNo config is gone for some reason. Not cool.

As long as this issue here isn't resolved the version in winget has to be 4 like it is when installed - even when this means that it breaks winget update functionality. Otherwise this always shows as an update being available for that particular app. I already created another PR to have that fixed.

@TCNOco As soon as this is fixed and for future versions you might consider using winget for updating the app and also could have your newest version automatically uploaded to the winget-pkgs repo. This could also help get some users updated from older versions like you mentioned here.