Closed virajchandra51 closed 1 year ago
Added All required Changes, except the default image. Please review the other stuff that was required. (PS - closed my last pull request by mistake, changes were - an abstract user and semester and branch choices to user)
LGTM. @sahil9001 review it once.
Change codechef id, codeforces id, leetcode id, gfg id, hackerrank id, linkedin id to urlfields
Change codechef id, codeforces id, leetcode id, gfg id, hackerrank id, linkedin id to urlfields
Done @ayushgoswamiabr
Why .github/pull_request_template.md
is removed? Unnecessary change, add it back
@ayushgoswamiabr @sahil9001 All changes are done
LGTM, @ayushgoswamiabr please verify changes locally. Then we can have approval.
@sahil9001 I have verified the changes locally there is no error just I think it would be better if phone number was an integer field with max value 9999999999 otherwise we would need checks to verify if user hasn't mistakenly entered characters in phone number
@sahil9001 I have verified the changes locally there is no error just I think it would be better if phone number was an integer field with max value 9999999999 otherwise we would need checks to verify if user hasn't mistakenly entered characters in phone number
Integers that big aren't supported yet, we prefer CharField
Ok
are any changes required sir? @ayushgoswamiabr
No
Fixes #18
Description
Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.
Type of Change: (Delete irrelevant options)
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.
Checklist:
Code/Quality Assurance