search

TCPShield / RealIP

The Spigot, Bungee and Velocity plugin that parses client IP addresses passed from the TCPShield network.
https://tcpshield.com
MIT License
145 stars 52 forks source link

Update the IP on publishing PreLoginEvent. (Bug Fix) #72

Open Rollczi opened 2 years ago

Rollczi commented 2 years ago

Linked bug: https://github.com/games647/FastLogin/pull/639

DylanKeir commented 2 years ago

Apologies, what's the purpose of this? You seem to have re-introduced an event which was previously causing issues due to not having the correct hostname data. I understand your approach might've been to have player#setIP called for the player to have the correct IP but AFAIK that's already handled on handshake and the handleHandshake is returned anyway if true is passed and the event spits out the erroneous data, which doesn't seem like an absolute fix for this. I need to do some debugging on my end with Velocity to figure out why sometimes the hostname passed is incorrect only for PreLoginEvent - I'll get back to you on this.

Rollczi commented 2 years ago

okey