Closed joehiggi1758 closed 4 months ago
Attention: Patch coverage is 0%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 97.31%. Comparing base (
3077d0d
) to head (5cb4929
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
min_versions.py | 0.00% | 17 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@joehiggi1758 I also recommend making your PR titles:
Fixed #XYZ Name of Corresponding Issue
The Fixed #XYZ
corresponds to issue number XYZ
and so when this PR gets closed/merged, it will also trigger the closing of issue XYZ
automatically.
Alright @joehiggi1758 everything looks good to me! Shall I merge this PR?
Alright @joehiggi1758 everything looks good to me! Shall I merge this PR?
Sounds great, that works for me!
@joehiggi1758 Thank you for this PR!
@seanlaw thank you for the opportunity!
… caputring all edge cases
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black
(i.e.,python -m pip install black
orconda install -c conda-forge black
)flake8
(i.e.,python -m pip install flake8
orconda install -c conda-forge flake8
)pytest-cov
(i.e.,python -m pip install pytest-cov
orconda install -c conda-forge pytest-cov
)black .
in the root stumpy directoryflake8 .
in the root stumpy directory./setup.sh && ./test.sh
in the root stumpy directory