TDAmeritrade / stumpy

STUMPY is a powerful and scalable Python library for modern time series analysis
https://stumpy.readthedocs.io/en/latest/
Other
3.67k stars 320 forks source link

[#996] updated min versions with test function to ensure our regex is… #1009

Closed joehiggi1758 closed 4 months ago

joehiggi1758 commented 4 months ago

… caputring all edge cases

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 97.31%. Comparing base (3077d0d) to head (5cb4929). Report is 2 commits behind head on main.

Files Patch % Lines
min_versions.py 0.00% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1009 +/- ## ========================================== - Coverage 97.41% 97.31% -0.11% ========================================== Files 89 89 Lines 14922 14950 +28 ========================================== + Hits 14537 14549 +12 - Misses 385 401 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seanlaw commented 4 months ago

@joehiggi1758 I also recommend making your PR titles:

  1. More brief/less verbose
  2. Or preferably Fixed #XYZ Name of Corresponding Issue

The Fixed #XYZ corresponds to issue number XYZ and so when this PR gets closed/merged, it will also trigger the closing of issue XYZ automatically.

seanlaw commented 4 months ago

Alright @joehiggi1758 everything looks good to me! Shall I merge this PR?

joehiggi1758 commented 4 months ago

Alright @joehiggi1758 everything looks good to me! Shall I merge this PR?

Sounds great, that works for me!

seanlaw commented 4 months ago

@joehiggi1758 Thank you for this PR!

joehiggi1758 commented 3 months ago

@seanlaw thank you for the opportunity!