Closed seanlaw closed 2 months ago
@NimaSarajpoor Does this seem right to you? Did I miss anything?
@seanlaw @NimaSarajpoor since this seems solid for a beginner like me, I'd be happy to take this one!
@joehiggi1758 It's all yours! Note that there is already a Sync Your Fork with the Parent Repository in our Contributing Guide but it is pretty light. I think the extra details above should/could go there but perhaps as a "hidden cell" (i.e., that the user would need to click a button to expand in order to see the details) via Myst-NB (the addition of Myst-NB is relatively new for STUMPY and we use it to render all of our tutorials, including the Contributor guide so PLEASE do not hesitate to ask if you get moderately stuck!).
Some additional notes:
Since this is dealing with documentation (hosted on readthedocs.org) and not stumpy development code, you will need to look inside of the docs
directory and install "documentation dependencies" by doing pip install -r requirements.txt
(this is in docs/requirements.txt
!!). After installing the dependencies, you can then "build" the docs locally by executing the setup.sh
script (also in docs/setup.sh
). A whole bunch of things will print to your screen as things are being built by sphinx (locally) and, at the end if you don't see any warnings/errors, you'll see something like:
The HTML pages are in _build/html.
Serving HTTP on :: port 8000 (http://[::]:8000/) ...
Do not "kill" this process as it is not running a local HTTP server that will allow you to view things from your browser and to check the rendered/built outputs. Then, fire up a browser tab and navigate to http://localhost:8000/_build/html/Contribute.html and you should be able to see your changes
Each time I fork the main repo and make a branch, I forget how to pull in changes from main into my local development branch. It would be good to document the basic steps in the Contributors guide:
cd Git/stumpy_dev.git
)git switch some_new_feature
)git add some_file.py
andgit commit
)git fetch upstream
)git checkout main
)git merge upstream/main
). This brings your fork's default branch into sync with the upstream repository, without losing your local changes.main
branch didn't have any unique commits, Git will perform a fast-forward. Otherwise, if your localmain
branch had unique commits, you may need to resolve conflicts. Note that this does not affect your development branch!git switch some_new_feature
)main
branch into your development branch (e.g.,git merge main
)You may see something like the following:
You will need to open up the files tagged with
CONFLICT
and resolve the merge conflicts. Once that's done, you will need to commit the changes and push the commit (e.g.,git push
) back to Github.