search

TDRA-ae / aegov-dls

The UAE Design System version 2.0 presents a manual for federal government entities (FGEs) of the United Arab Emirates to plan and arrange content on their websites with simplicity and creativity.
https://designsystem.gov.ae
MIT License
25 stars 6 forks source link

[Bug] Header Menu Item Hover Effect Not Matching DLS Component #51

Closed jamaljaba closed 1 month ago

jamaljaba commented 2 months ago

We are in the process of implementing the updated header component. However, after rendering the CSS file, the result does not match the expected behavior of the DLS component. For example, in the DLS component, hovering over a menu item displays the item with a background color, whereas in our implementation, it only underlines the text.

Design System Version: 2.2.4

For reference kindly check attachments. imlemented-header-in our-local design-sytem-header

moiz-conceptlz commented 1 month ago

Indeed, the background color on the links was part of our initial release.

Feedback from various entities proved that forcing a background color was not a good idea. Hence, we updated the design system component in the plugin to reflect the basic behaviour.

We will updaet the component example itself as well - thank you for sharing this.

I want to take this oppertunity to describe that the dropdown navigation is only a guide. You may choose to add a layout in the dropdown that is most usable towards the number of links and experience you wish to provide.