search

TDRA-ae / aegov-dls

The UAE Design System version 2.0 presents a manual for federal government entities (FGEs) of the United Arab Emirates to plan and arrange content on their websites with simplicity and creativity.
https://designsystem.gov.ae
MIT License
25 stars 6 forks source link

[BUG] Background and foreground colors do not have a sufficient contrast ratio #66

Closed Sa7aR-Kassem closed 1 day ago

Sa7aR-Kassem commented 1 week ago

Take a moment to review - is it really a bug? Or is it more of an enhancement or a typo in the documentation? A Bug is code that is broken, or when you try to implement a certain piece of code that is mentioned in the documentation, you have a result that is not the same as described.

Now if you are absolutely sure it is indeed a bug, please fill in the following template.

Mention what part of the design system the bug is related to Is the bug part of a "Card", a "Button", a "Anchor" the

More context in relation to the design system If the bug is part of a component or a block, please mention which one. If the bug is related to the plugin, please mention if it is during installation, compiling or configuration.

Describe the bug A clear and concise description of what the bug is. Help us understand what you are doing that is causing an error.

To Reproduce Steps to reproduce the behavior:

  1. Go to any anchor have the color aegold-600 & background-color bg-white
  2. Test accessibility by wave tool or lighthouse chrome tab
  3. Having low contrast color issue

Expected behavior Passing color contrast checking

Screenshots If applicable, add screenshots to help explain your problem. This is not mandatory, but definitely helpful.

A bit more context about the browser

Is the issue on both Desktop and Smartphones? Yes on both. Here is where I tested it:

Additional context Add any other context about the problem here.

moiz-conceptlz commented 6 days ago

@Sa7aR-Kassem

Sharing with you a screenshot of the contrast testing tool for AEGOLD-600 which translates to a hex value of #92722A and a background color of white - which translates to #FFFFFF

Also, be default, all in the design system are coded to have a font weight on about 500 or 600, which is considered as a medium or semi bold.

Please confirm if you are using the same hex values and share a screenshot of your your test results that show it as a failed for a AA compatibility.

Screenshot 2024-11-20 at 10 08 45 AM
moiz-conceptlz commented 1 day ago

Closing this, as this is not an issue.