TDycores-Project / TDycore

BSD 2-Clause "Simplified" License
4 stars 0 forks source link

Fixes Neumann bc and TPF for MPFA-O #101

Closed bishtgautam closed 4 years ago

bishtgautam commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #101 into master will increase coverage by 3.39%. The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   81.90%   85.29%   +3.39%     
==========================================
  Files          45       46       +1     
  Lines        9973    11823    +1850     
==========================================
+ Hits         8168    10085    +1917     
+ Misses       1805     1738      -67     
Impacted Files Coverage Δ
src/tdyutils.c 85.32% <0.00%> (-2.38%) :arrow_down:
src/mesh/tdycoremesh.c 94.91% <100.00%> (+2.06%) :arrow_up:
src/mpfao/3D/tdympfao3D_core.c 98.42% <100.00%> (+0.88%) :arrow_up:
src/mpfao/3D/tdympfao3D_ts.c 98.26% <100.00%> (+0.63%) :arrow_up:
src/mpfao/3D/tdympfao3D_steady.c 100.00% <0.00%> (ø)
src/mpfao/3D/tdympfao3D_ts_dae.c 0.00% <0.00%> (ø)
src/mpfao/3D/tdympfao3D_ts_transientvar.c 0.00% <0.00%> (ø)
src/tdyrichards.c 100.00% <0.00%> (ø)
src/tdytpf.c 98.97% <0.00%> (+0.19%) :arrow_up:
src/mpfao/3D/tdympfao3D_snes.c 97.67% <0.00%> (+0.37%) :arrow_up:
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e853b1...6304e4a. Read the comment docs.

ghammond86 commented 4 years ago

Are you okay with me merging even though the patch has lower codecov coverage?

bishtgautam commented 4 years ago

Yes, I'm okay with lower code coverage.